Skip to content

[common] Update manifest role and config #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[common] Update manifest role and config #279

wants to merge 1 commit into from

Conversation

@elfiesmelfie
Copy link
Collaborator

@elfiesmelfie elfiesmelfie commented Jun 9, 2025

  • Use a list of strings, instead of a space-separated string
  • Remove the string separating tasks
  • Replace wc -l with stdout_lines | length
  • Name the loop var

ayefimov-1
ayefimov-1 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@ayefimov-1 ayefimov-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good.

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Jul 1, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7bfdec45f3ff4ee8af74b63280096267

❌ openstack-k8s-operators-content-provider FAILURE in 12m 06s
⚠️ functional-autoscaling-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ functional-logging-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@elfiesmelfie
[common] Update manifest role and config
86adbaa 
* Use a list of strings, instead of a space-separated string
* Remove the string separating tasks
* Replace `wc -l` with stdout_lines | length
* Name the loop var
@elfiesmelfie elfiesmelfie force-pushed the efoley/update_manifest_tests branch from 5b6e3ac to 86adbaa Compare July 4, 2025 17:58
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Jul 4, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87925265dc11473dad903dbaff8759a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 52m 14s
❌ functional-autoscaling-tests-osp18 FAILURE in 2h 36m 33s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 09m 35s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyzigold vyzigold vyzigold approved these changes

@ayefimov-1 ayefimov-1 ayefimov-1 approved these changes

@mgirgisf mgirgisf Awaiting requested review from mgirgisf

@lnatapov lnatapov Awaiting requested review from lnatapov

@myadla myadla Awaiting requested review from myadla

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elfiesmelfie @vyzigold @ayefimov-1